Skip to content

[php-nextgen]: Fix imports for models with parent schema#23317

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
coffeemakr:feature/php-nextgen-parentschema-imports
Mar 26, 2026
Merged

[php-nextgen]: Fix imports for models with parent schema#23317
wing328 merged 1 commit intoOpenAPITools:masterfrom
coffeemakr:feature/php-nextgen-parentschema-imports

Conversation

@coffeemakr
Copy link
Contributor

@coffeemakr coffeemakr commented Mar 23, 2026

The models with parent schema are missing imports.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Adds missing imports to php-nextgen models with a parent schema to prevent undefined class errors and improve IDE support.

  • Bug Fixes
    • Updated model.mustache to add InvalidArgumentException, ReturnTypeWillChange, and ObjectSerializer when parentSchema is present.
    • Regenerated affected PHP samples (e.g., DataQuery, Cat, Dog) to include the imports.

Written for commit 140fd45. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

@wing328
Copy link
Member

wing328 commented Mar 23, 2026

thanks for the pr

cc @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

@wing328 wing328 merged commit dd4b8c1 into OpenAPITools:master Mar 26, 2026
20 of 21 checks passed
@wing328
Copy link
Member

wing328 commented Mar 26, 2026

@coffeemakr thanks for the PR which has been merged.

Can you please PM me via Slack when you've time?

https://join.slack.com/t/openapi-generator/shared_invite/zt-36ucx4ybl-jYrN6euoYn6zxXNZdldoZA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants